Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarified OMP_NUM_THREADS #835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

clarified OMP_NUM_THREADS #835

wants to merge 1 commit into from

Conversation

zerothi
Copy link

@zerothi zerothi commented Dec 4, 2024

Removed description of possible deprecation of OMP_NUM_THREADS.

After discussion in #825 it was agreed to:

  • lax the deprecation warning, OMP_NUM_THREADS will always be a fall-bock.
  • Clarified with a simple example on how to do different regions of thread-counts.

@zerothi
clarified OMP_NUM_THREADS
f60a943 
Removed description of possible deprecation of OMP_NUM_THREADS.

After discussion in flame#825 it was agreed to:

- lax the deprecation warning, OMP_NUM_THREADS will always be a fall-bock.
- Clarified with a simple example on how to do different
  regions of thread-counts.

Signed-off-by: Nick Papior <[email protected]>
@zerothi
Copy link
Author

zerothi commented Dec 4, 2024

What is not clear from the current document is how the BLIS_IC_NT and friends interact with the default number of threads. I didn't mention it currently.

I think this solves #825

@devinamatthews
Copy link
Member

Setting any of the BLIS_XX_NT values will override BLIS_NUM_THREADS and OMP_NUM_THREADS. Unset BLIS_XX_NT values are taken as 1. (@fgvanzee check me on this)

@fgvanzee
Copy link
Member

fgvanzee commented Dec 4, 2024

What is not clear from the current document is how the BLIS_IC_NT and friends interact with the default number of threads. I didn't mention it currently.

I think this solves #825

This is actually already mentioned in the document under "Specifying multithreading." It's even in bold.

Note: Please be aware of what happens if you try to specify both the automatic and manual ways, as it could otherwise confuse new users. Here are the important points:

  • Regardless of which of the three methods is used, if multithreading is specified via both the automatic and manual ways, the values set via the manual way will always take precedence.

@zerothi
Copy link
Author

zerothi commented Dec 5, 2024

Sorry for the mislead, I just didn't see it in the mentioned section. But I suppose that is not necessary, so please forget my comment.

I think the PR still remains final, let me know if you need any changes, I'll amend!

@fgvanzee
Copy link
Member

fgvanzee commented Dec 5, 2024

Sorry for the mislead, I just didn't see it in the mentioned section. But I suppose that is not necessary, so please forget my comment.

I think the PR still remains final, let me know if you need any changes, I'll amend!

No problem. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zerothi @devinamatthews @fgvanzee